Skip to content

Return empty IndexLookup if Literal type is not convertible to column type#10259

Merged
angelamayxie merged 6 commits intomainfrom
angela/key_conversion
Jan 3, 2026
Merged

Return empty IndexLookup if Literal type is not convertible to column type#10259
angelamayxie merged 6 commits intomainfrom
angela/key_conversion

Conversation

@angelamayxie
Copy link
Copy Markdown
Contributor

@angelamayxie angelamayxie commented Jan 2, 2026

fixes #10246

test added in dolthub/go-mysql-server#3360

@coffeegoddd
Copy link
Copy Markdown
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
40cdc07 ok 5937471
version total_tests
40cdc07 5937471
correctness_percentage
100.0

@angelamayxie angelamayxie marked this pull request as ready for review January 2, 2026 21:40
@angelamayxie angelamayxie requested a review from zachmu January 2, 2026 21:40
@coffeegoddd
Copy link
Copy Markdown
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
454c815 ok 5937471
version total_tests
454c815 5937471
correctness_percentage
100.0

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Copy Markdown
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3d9adfc ok 5937471
version total_tests
3d9adfc 5937471
correctness_percentage
100.0

@angelamayxie angelamayxie merged commit 8e3dba6 into main Jan 3, 2026
23 checks passed
@angelamayxie angelamayxie deleted the angela/key_conversion branch January 3, 2026 01:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 3, 2026

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.6
adds_updates_deletes 60000 60000 60000 3.13
deletes_only 0 60000 0 1.54
updates_only 0 0 60000 2.02

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 3, 2026

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 1.8
batching batch sql 10000 1 0.06 2
batching by line sql 10000 1 0.08 1.5
blob 1 blob 200000 1 0.86 4.31 4.31
blob 2 blobs 200000 1 0.81 5.06 4.88
blob no blob 200000 1 0.86 2.78 2.65
col type datetime 200000 1 0.74 2.82 2.5
col type varchar 200000 1 0.66 3.94 3.61
config width 2 cols 200000 1 0.75 2.71 2.41
config width 32 cols 200000 1 1.74 3.3 2.82
config width 8 cols 200000 1 0.88 3.08 2.7
pk type float 200000 1 0.82 2.55 2.73
pk type int 200000 1 0.73 2.81 2.53
pk type varchar 200000 1 1.35 1.89 1.81
row count 1.6mm 1600000 1 5.3 3.15 2.73
row count 400k 400000 1 1.39 2.99 2.59
row count 800k 800000 1 2.65 3.13 2.72
secondary index four index 200000 1 3.34 1.4 1.12
secondary index no secondary 200000 1 0.81 2.95 2.81
secondary index one index 200000 1 1.07 2.68 2.36
secondary index two index 200000 1 1.83 1.91 1.66
sorting shuffled 1mm 1000000 0 5.01 3.03 2.67
sorting sorted 1mm 1000000 1 5.06 3.01 2.64

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 3, 2026

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.19
dolt_blame_commit_filter system table 2.64
dolt_commit_ancestors_commit_filter system table 0.58
dolt_commits_commit_filter system table 1.06
dolt_diff_log_join_from_commit system table 2.55
dolt_diff_log_join_to_commit system table 2.55
dolt_diff_table_from_commit_filter system table 1.22
dolt_diff_table_to_commit_filter system table 1.23
dolt_diffs_commit_filter system table 1.14
dolt_history_commit_filter system table 1.71
dolt_log_commit_filter system table 1.12

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 4, 2026

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.6
adds_updates_deletes 60000 60000 60000 3.06
deletes_only 0 60000 0 1.49
updates_only 0 0 60000 1.97

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 4, 2026

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 2
batching batch sql 10000 1 0.06 2.17
batching by line sql 10000 1 0.06 2
blob 1 blob 200000 1 0.85 4.24 4.24
blob 2 blobs 200000 1 0.84 4.8 4.54
blob no blob 200000 1 0.87 2.78 2.57
col type datetime 200000 1 0.81 2.56 2.37
col type varchar 200000 1 0.63 4.03 3.76
config width 2 cols 200000 1 0.74 2.72 2.49
config width 32 cols 200000 1 1.67 3.43 2.92
config width 8 cols 200000 1 0.96 2.78 2.58
pk type float 200000 1 0.82 2.52 2.27
pk type int 200000 1 0.75 2.69 2.44
pk type varchar 200000 1 1.39 1.83 1.63
row count 1.6mm 1600000 1 5.58 2.97 2.66
row count 400k 400000 1 1.42 2.89 2.57
row count 800k 800000 1 2.76 2.99 2.65
secondary index four index 200000 1 3.46 1.33 1.14
secondary index no secondary 200000 1 0.87 2.76 2.55
secondary index one index 200000 1 1.09 2.6 2.22
secondary index two index 200000 1 1.85 1.86 1.88
sorting shuffled 1mm 1000000 0 5 3.08 2.8
sorting sorted 1mm 1000000 1 5.1 3.02 2.84

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 4, 2026

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.23
dolt_blame_commit_filter system table 2.64
dolt_commit_ancestors_commit_filter system table 0.6
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.93
dolt_diff_log_join_to_commit system table 2.95
dolt_diff_table_from_commit_filter system table 1.23
dolt_diff_table_to_commit_filter system table 1.18
dolt_diffs_commit_filter system table 1.13
dolt_history_commit_filter system table 1.48
dolt_log_commit_filter system table 1.14

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.63
adds_updates_deletes 60000 60000 60000 3.11
deletes_only 0 60000 0 1.49
updates_only 0 0 60000 2.04

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.67
batching batch sql 10000 1 0.08 1.63
batching by line sql 10000 1 0.08 1.63
blob 1 blob 200000 1 0.9 4.19 4.36
blob 2 blobs 200000 1 0.92 4.46 4.29
blob no blob 200000 1 0.91 2.71 2.64
col type datetime 200000 1 0.82 2.63 2.55
col type varchar 200000 1 0.66 3.85 3.83
config width 2 cols 200000 1 0.81 2.83 2.4
config width 32 cols 200000 1 1.94 3.07 2.62
config width 8 cols 200000 1 0.98 2.92 2.55
pk type float 200000 1 0.88 2.42 2.32
pk type int 200000 1 0.78 2.71 2.53
pk type varchar 200000 1 1.52 1.73 1.59
row count 1.6mm 1600000 1 5.83 2.94 2.73
row count 400k 400000 1 1.49 2.82 2.63
row count 800k 800000 1 2.95 2.91 2.66
secondary index four index 200000 1 3.59 1.35 1.1
secondary index no secondary 200000 1 0.91 2.75 2.65
secondary index one index 200000 1 1.13 2.6 2.29
secondary index two index 200000 1 2.05 1.74 1.66
sorting shuffled 1mm 1000000 0 5.08 2.9 2.68
sorting sorted 1mm 1000000 1 5.2 2.83 2.61

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.22
dolt_blame_commit_filter system table 2.59
dolt_commit_ancestors_commit_filter system table 0.63
dolt_commits_commit_filter system table 1
dolt_diff_log_join_from_commit system table 2.88
dolt_diff_log_join_to_commit system table 2.92
dolt_diff_table_from_commit_filter system table 1.17
dolt_diff_table_to_commit_filter system table 1.22
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.57
dolt_log_commit_filter system table 1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Booleans should not be used as keys for varchar index lookups

3 participants