Return nil lookupMapping if type conversion is not in range for lookup key#10248
Merged
angelamayxie merged 7 commits intomainfrom Dec 30, 2025
Merged
Return nil lookupMapping if type conversion is not in range for lookup key#10248angelamayxie merged 7 commits intomainfrom
angelamayxie merged 7 commits intomainfrom
Conversation
Contributor
|
@angelamayxie DOLT
|
Contributor
|
@angelamayxie DOLT
|
zachmu
reviewed
Dec 30, 2025
Member
zachmu
left a comment
There was a problem hiding this comment.
Probably should use the same logic for this that GMS does, this seems like it was just an oversight when the latest round of bug fixes for this problem were just applied ther.
Contributor
|
@angelamayxie DOLT
|
[auto-bump] [no-release-notes] dependency by angelamayxie
Contributor
|
@angelamayxie DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10233
Not checking if a value is in the converted range was causing us to use incorrect keys. For example, if the literal
-87840was used as a key for a boolean/tinyint column, it would get converted to-128and match rows with-128, even though that's not the same value.This change checks for if a conversion is
InRange, and if it's not, it returns a nillookupMapping. The nillookupMappingwill then return false when*lookupMapping.valid()is called.Test added in dolthub/go-mysql-server#3357