Conversation
Contributor
Author
|
#benchmark |
Contributor
Contributor
Contributor
|
@coffeegoddd DOLT
|
Contributor
|
@jycor DOLT
|
Contributor
Author
|
#benchmark |
Contributor
Contributor
|
@jycor DOLT
|
Contributor
Author
|
#benchmark |
Contributor
Contributor
Contributor
|
@jycor DOLT
|
fulghum
approved these changes
Dec 23, 2025
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Change looks good. Just wanted to double check the impact of removing the older geometry type encoding.
Comment on lines
-209
to
-218
| // TODO: until GeometryEnc is removed, we must check if GeomAddrEnc is a GeometryEnc | ||
| var ok bool | ||
| v.Val, ok = td.GetGeometry(i, tup) | ||
| if ok { | ||
| _, err = deserializeGeometry(v.Val) // TODO: on successful deserialize, this work is wasted | ||
| if err == nil { | ||
| return v, nil | ||
| } | ||
| } | ||
| // TODO: have GeometryAddr implement TextStorage |
Contributor
There was a problem hiding this comment.
How long has GeometryEnc been removed? Is there a risk customers will still have databases that have this encoding and can't be read with this latest change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the runtime is taken up by
mapaccess, which isn't necessary; this PR gets rid of it.