Skip to content

[no-release-notes] avoid heap allocs in transform bump #10222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jycor merged 4 commits into from
Dec 17, 2025
Merged

[no-release-notes] avoid heap allocs in transform bump #10222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88c4ccc
fix
Dec 17, 2025
cfc1014
bump
Dec 17, 2025
0f7099e
bump
Dec 17, 2025
53159a1
bump
Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ require (
github.com/dolthub/dolt-mcp v0.2.2
github.com/dolthub/eventsapi_schema v0.0.0-20250915094920-eadfd39051ca
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
github.com/dolthub/go-mysql-server v0.20.1-0.20251216004316-fc7d04573784
github.com/dolthub/go-mysql-server v0.20.1-0.20251217221004-60f4b0ac4e4b
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63
github.com/edsrzf/mmap-go v1.2.0
github.com/esote/minmaxheap v1.0.0
Expand Down
4 changes: 2 additions & 2 deletions go/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ github.com/dolthub/fslock v0.0.0-20251215194149-ef20baba2318 h1:n+vdH5G5Db+1qnDC
github.com/dolthub/fslock v0.0.0-20251215194149-ef20baba2318/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
github.com/dolthub/go-icu-regex v0.0.0-20250916051405-78a38d478790 h1:zxMsH7RLiG+dlZ/y0LgJHTV26XoiSJcuWq+em6t6VVc=
github.com/dolthub/go-icu-regex v0.0.0-20250916051405-78a38d478790/go.mod h1:F3cnm+vMRK1HaU6+rNqQrOCyR03HHhR1GWG2gnPOqaE=
github.com/dolthub/go-mysql-server v0.20.1-0.20251216004316-fc7d04573784 h1:gtN9Z4B7+EBvP0gBUjS0M39hI4wtc2R06oq/qaB98fw=
github.com/dolthub/go-mysql-server v0.20.1-0.20251216004316-fc7d04573784/go.mod h1:NjewWKoa5bVSLdKwL7fg7eAfrcIxDybWUKoWEHWRTw4=
github.com/dolthub/go-mysql-server v0.20.1-0.20251217221004-60f4b0ac4e4b h1:kt3OjUw2sO6QHEvfhgvTOPNFOQxjYYx7ol4zHIw5xYQ=
github.com/dolthub/go-mysql-server v0.20.1-0.20251217221004-60f4b0ac4e4b/go.mod h1:NjewWKoa5bVSLdKwL7fg7eAfrcIxDybWUKoWEHWRTw4=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q=
github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE=
Expand Down
4 changes: 2 additions & 2 deletions go/libraries/doltcore/sqle/dfunctions/hashof.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const DeprecatedHashOfFuncName = "hashof"
const HashOfFuncName = "dolt_hashof"

type HashOf struct {
expression.UnaryExpression
expression.UnaryExpressionStub
name string
}

Expand All @@ -47,7 +47,7 @@ func NewHashOfFunc(name string) sql.CreateFunc1Args {

// newHashOf creates a new HashOf expression.
func newHashOf(e sql.Expression, name string) sql.Expression {
return &HashOf{expression.UnaryExpression{Child: e}, name}
return &HashOf{expression.UnaryExpressionStub{Child: e}, name}
}

// Eval implements the Expression interface.
Expand Down
4 changes: 2 additions & 2 deletions go/libraries/doltcore/sqle/dfunctions/hashof_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ import (
const HashOfTableFuncName = "dolt_hashof_table"

type HashOfTable struct {
expression.UnaryExpression
expression.UnaryExpressionStub
}

var _ sql.FunctionExpression = (*HashOfTable)(nil)

// NewHashOfTable creates a new HashOfTable expression.
func NewHashOfTable(e sql.Expression) sql.Expression {
return &HashOfTable{expression.UnaryExpression{Child: e}}
return &HashOfTable{expression.UnaryExpressionStub{Child: e}}
}

// Eval implements the Expression interface.
Expand Down
Loading