Move variables to inner scope - DolphinQT #13190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Nov 16, 2024
tygyh
force-pushed
the
Move-to-inner-scope-DolphinQT
branch
from
0c36f88 to
04bc072
Compare
|
@dolphin-emu-bot rebuild |
tygyh
changed the title
mitaclaw
reviewed
Nov 24, 2024
|
|
||
| if (is_down) | ||
| { | ||
| utf8 = key_event->text().toUtf8(); | ||
| QByteArray utf8 = key_event->text().toUtf8(); |
There was a problem hiding this comment.
This is an object lifetime issue. With this change, const char* chars will still contain the result of utf8.constData() after QByteArray utf8 goes out of scope. This is why the code was written the way it was before. This is not the first time your automated changes have produced erroneous code like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial replacement of #13026