fix(replacer): errors suppressed by catch statement #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2856 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 281 281
Lines 14139 14143 +4
Branches 1389 1389
=========================================
+ Hits 14139 14143 +4 ☔ View full report in Codecov by Sentry. |
dolanmiu
approved these changes
Nov 28, 2024
|
Does this fix #2855? |
No, it only makes it so that the faulty code no longer silently fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of
replacerso that it returns a boolean to signify whether patches were found rather than throwing.Impact on clients:
Relates to #2855