Allow disabling numbering inherited from a paragraph style #2531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 280 280
Lines 14021 14025 +4
Branches 1369 1370 +1
=========================================
+ Hits 14021 14025 +4 ☔ View full report in Codecov by Sentry. |
|
Hi @dolanmiu, have you had a chance to look over this? |
| @@ -135,6 +137,8 @@ export class ParagraphProperties extends IgnoreIfEmptyXmlComponent { | |||
| }); | |||
|
|
|||
| this.push(new NumberProperties(`${options.numbering.reference}-${options.numbering.instance ?? 0}`, options.numbering.level)); | |||
| } else if (options.numbering === false) { | |||
There was a problem hiding this comment.
Better to check for undefined I think rather than false, so it is idiomatic with this library
There was a problem hiding this comment.
If we check for undefined then we'll be disabling inherited numbering by default (not what we're looking for), unless we treat undefined different to a missing value.
Maybe null is a better fit than undefined then?
There was a problem hiding this comment.
@dolanmiu Any thoughts?
There was a problem hiding this comment.
I see what you mean
Yes looks good, I like how it can be set to false, which has clear intent
Approved, merging
No description provided.