feat(bot-mode): retrieve Group Chat files in Desktop - #1
Draft
dokterdok wants to merge 15 commits into
Draft
Conversation
(cherry picked from commit b412108)
(cherry picked from commit 80755ef)
Keep retry available after the room settles without hiding healthy ongoing work. Consume both explicit attention and existing pending actions from older hosts. Verified with 25 runtime tests. (cherry picked from commit 1391168)
…desktop-group-files-20260905
(cherry picked from commit b9d34be2b8f890df970c7ab0a76d17619049f1ec)
(cherry picked from commit bf95af28699aa04f518f143b86a6e30ae90ed68b)
૮ >ﻌ< ა ci reviewrunning on a70261f — fix(desktop): bring Files recovery source to reviewed field Still running 1 job:
|
This was referenced Sep 5, 2026
Draft
…7846 Merge exact prerequisite e2b8640 into the preserved Files source at 54c248d. Preserve both authored histories and compose overlapping Files and command-lease signatures without duplicating generic mailbox commits. Reuse the group-chat.ts comment from reviewed field 25cda8f to keep the composed owner strictly below 2000 physical lines. Files-specific recovery fences follow separately.
Copy only the Files-specific final owner contents from reviewed field 25cda8f. Generic classic messaging is already inherited through the exact NousResearch#97846 prerequisite merge; no backend or unrelated field owners are imported. Source-commit: 25cda8f Preserved-recovery-commits: da19f696f5a3cd1705f5624c8f30b069d483a02e, 342484a92199f6746ae5a382636df0f0876ef87d, 3e402c4dac1359c0304d2cd8a3a2ddd1ebe147c8, 467131c92a880f0302702edaea48a7ae220a9fee The group-chat.ts comment from the same source was included in the prerequisite merge to keep that intermediate owner below 2000 physical lines. All five recovery paths now match the reviewed field byte-for-byte.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find The File Without Scrolling Back Through The Chat
Open Files in a Group Chat to find what people and Bots shared, search by filename or sharer, distinguish revisions, and download the selected file. Newest shares come first; opening the browser does not ask a model to recreate a result.
This is a focused source draft in the contributor fork, based on the Desktop continuity branch from NousResearch#97846. It keeps Files out of that maintainer-requested Desktop-client-only change and avoids a second upstream PR carrying its entire prerequisite diff. The complete running test composition remains NousResearch#98307; the product and merge direction remain in NousResearch#97681.
What You Can Do
Scope And Dependencies
The change is Desktop-only. It adds no gateway storage, messaging enrollment, authority election or new round scheduler.
Verification
Current source:
a70261f61ecf96eab4cbebd141aa6c86523cd019, including exact Desktop prerequisitee2b8640dd5through a history-preserving merge.54c248d995baseline passed 1,219 tests across 93 files; these overlapping counts are not additive.Latest Recovery Work
The end-to-end build is NousResearch/hermes-agent#98307. Classic file recovery stays bound to the originating messaging command and cannot replay an older task after newer work. The applicable repairs from preserved field commit
25cda8f8f7are now included here, with their author and original commit references retained.The updated Desktop prerequisite is included once, not recreated as Files code. Use the pinned complete integration build for end-to-end testing; do not assemble moving sibling branches by hand. The classic exporter backend in fork PR #2 required no exporter-specific code update.
Earlier real-client evidence and remaining acceptance checks
The earlier source-only built Electron journeys passed classic upload/download/reopen and hosted search/version/download/reopen against a separate Files backend. Live field testing subsequently retrieved two Bot-created same-name Markdown versions through the packaged Desktop, matching each canonical file hash. Signal retrieved the same shared bytes while Desktop was closed.
Those are bounded receipts, not a claim that every topology was rerun on this source head. The matching integration build now completed a natural classic producer-to-reviewer handoff in a six-Bot Group Chat: the writer shared a new 2,917-byte Markdown revision, the remote reviewer checked its arithmetic and timing, and the Desktop download matched the producer's canonical SHA-256. The final recovery/topology cases remain in progress.
Original implementation and repair commits are preserved, including the separately cherry-pickable classic consumer. This draft is a source/review boundary, not a request to bypass the maintainer's continuity timeline.