Fixed the backup-unset-public-key-encryption command. #336
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoelter
commented
Jan 5, 2025
| @@ -433,7 +433,7 @@ service_backup_set_encryption() { | |||
| local SERVICE_ROOT="${PLUGIN_DATA_ROOT}/${SERVICE}" | |||
| local SERVICE_BACKUP_ENCRYPTION_ROOT="${SERVICE_ROOT}/backup-encryption/" | |||
|
|
|||
| mkdir "$SERVICE_BACKUP_ENCRYPTION_ROOT" | |||
There was a problem hiding this comment.
Added '-p' flag to prevent this command from failing if the encryption directory already exists. This will occur after an encryption type was set and then removed.
hoelter
commented
Jan 5, 2025
| } | ||
|
|
||
| service_backup_unset_encryption() { |
There was a problem hiding this comment.
This was a duplicate of the above function prior to this change.
hoelter
commented
Jan 5, 2025
|
|
||
| [[ -z "$SERVICE" ]] && dokku_log_fail "Please specify a valid name for the service" | ||
| verify_service_name "$SERVICE" | ||
| service_backup_unset_public_key_encryption "$SERVICE" # TODO: [22.03.2024 by Mykola] | ||
| service_backup_unset_public_key_encryption "$SERVICE" |
There was a problem hiding this comment.
This wasn't pointing to an actual function and would blow up at this point prior to the above change in common-functions.
hoelter
commented
Jan 5, 2025
| @@ -13,11 +13,11 @@ service-backup-unset-public-key-encryption-cmd() { | |||
| local cmd="$PLUGIN_COMMAND_PREFIX:backup-unset-public-key-encryption" argv=("$@") | |||
| [[ ${argv[0]} == "$cmd" ]] && shift 1 | |||
| declare SERVICE="$1" | |||
| is_implemented_command "$cmd" || dokku_log_fail "Not yet implemented" # TODO: [22.03.2024 by Mykola] | |||
| is_implemented_command "$cmd" || dokku_log_fail "Not yet implemented" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "backup-unset-public-key-encryption" is not currently functioning. These changes resolve that.
I updated the set / unset functions to enable removing either the public-key-encryption or the encryption-passphrase in isolation without removing the other and added some notes to the readme.