Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Identifier Under Caret & Search Result Backgrounds #373

Merged
merged 10 commits into from
Apr 10, 2021

Conversation

Unthrottled
Copy link
Member

Description

  • Removed searchResultBackground and replaced with foldedTextBackground
  • Added a new color identifierHighlight which contrasts with the editor background.
  • And a bunch of other small things.

I did this for all 44 themes

I regret everything

😅

Motivation and Context

Closes #370

Screenshots (if appropriate):

Before After
Screenshot from 2021-04-09 18-52-35 Screenshot from 2021-04-09 19-02-25

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project (./gradlew check passes clean).
    • Tip: If you have lint issues just run ./gradlew :ktlintMainSourceSetFormat.
  • I updated the version.
  • I updated the changelog with the new functionality.

@Unthrottled Unthrottled added bug Something isn't working usability labels Apr 10, 2021
@Unthrottled Unthrottled merged commit dcb86cc into master Apr 10, 2021
@Unthrottled Unthrottled deleted the highlightFixes branch April 10, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion for better color contrast
1 participant