Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong Sticker Positioning on resizing #482

Closed
Dragon-0609 opened this issue Jan 19, 2022 · 3 comments · Fixed by #488
Closed

[BUG] Wrong Sticker Positioning on resizing #482

Dragon-0609 opened this issue Jan 19, 2022 · 3 comments · Fixed by #488
Labels
bug Something isn't working

Comments

@Dragon-0609
Copy link
Contributor

Describe the bug
I just noticed that the sticker is anchored to the bottom|right of the IDE. If I want to put it let's say to the bottom|left part, it'll be there if I don't resize the IDE. But if I resize from 1920x1080 to for example 1280x720, the sticker will float somewhere in the window. In fact, I don't resize the IDE to the small window. But even if I don't resize it, it still needs to be fixed.

To Reproduce

  1. Enable Sticker Positioning
  2. Be sure that your window is fullscreen
  3. Change its position to somewhere except the right anchor (for example to the bottom left)
  4. Resize it to the small window
  5. See the floating sticker

Expected Behavior
I expect the sticker to stay in its place. I worked a lot to make this feature in Yuki Theme. I didn't even think that you hadn't finished the sticker positioning in other anchors (alignments: bottom| center |top and etc...).

Environment
PyCharm 2021.2.2
Build #PY-212.5284.44, built on September 14, 2021
Runtime version: 11.0.12+7-b1504.28 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
Memory: 1022M
Cores: 4
Registry: ide.intellij.laf.enable.animation=true
Non-Bundled Plugins: io.unthrottled.theme.randomizer (0.2.0), io.acari.normandy.progress.bar (1.9.10), io.acari.DDLCTheme (22.3.0), io.unthrottled.amii (0.13.0), izhangzhihao.rainbow.brackets (6.21)

Videos

Video of the bug:

bandicam.2022-01-19.21-21-21-138.mp4

Video of right sticker positioning:

bandicam.2022-01-19.21-25-30-351.mp4
@Unthrottled Unthrottled added the bug Something isn't working label Jan 19, 2022
@Unthrottled
Copy link
Member

Ah yeah, I think I know what the issue is.

I just need to update the window resize positioning code to calculate the new position relative to the last one, correctly (like the save positioning feature).

Thanks for taking the time to report the issue.

@Unthrottled
Copy link
Member

So I've got the issue worked out for the most part.

There still is a few bugs, but they aren't worth the effort of addressing. Right now, I'm only going to support bottom right anchoring. So I'll save the position & move the position relative to the bottom right hand corner of the window. This causes the sticker to be pushed off when the bottom right hand corner moves closer to the top left. I don't feel like making more spaghetti code to address the issue for all positions, cause stickers should be put in the bottom right hand corner.

bandicam.2022-01-30.18-21-56-237.mp4

@Dragon-0609
Copy link
Contributor Author

It's better than the previous version.
BTW, it's a nice theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants