Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Widget #569

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Grid Widget #569

merged 1 commit into from
Sep 6, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Aug 22, 2018

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Ports le-grid to dojo widgets.

Needs a11y and styling review after merging to ensure they are inline with expectations for a dojo widget.

Resolves: #570

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #569 into master will decrease coverage by 0.98%.
The diff coverage is 91.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   99.61%   98.63%   -0.99%     
==========================================
  Files          32       42      +10     
  Lines        2615     2997     +382     
  Branches      749      806      +57     
==========================================
+ Hits         2605     2956     +351     
- Misses         10       41      +31
Impacted Files Coverage Δ
src/grid/index.ts 100% <100%> (ø)
src/grid/widgets/Footer.ts 100% <100%> (ø)
src/grid/utils.ts 100% <100%> (ø)
src/grid/widgets/PlaceholderRow.ts 100% <100%> (ø)
src/grid/widgets/Cell.ts 100% <100%> (ø)
src/grid/widgets/Header.ts 75% <75%> (ø)
src/grid/widgets/Grid.ts 81.35% <81.35%> (ø)
src/grid/widgets/Row.ts 88.88% <88.88%> (ø)
src/grid/processes.ts 93.42% <93.42%> (ø)
src/grid/widgets/Body.ts 95.49% <95.49%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab484d...3c9731b. Read the comment docs.

@agubler agubler merged commit 85f5672 into dojo:master Sep 6, 2018
tomdye added a commit that referenced this pull request Nov 7, 2019
* add focus meta with restrained invalidate

* change uses of focus to use local meta
tomdye added a commit to tomdye/widgets that referenced this pull request Nov 7, 2019
* add focus meta with restrained invalidate

* change uses of focus to use local meta
matt-gadd pushed a commit that referenced this pull request Nov 11, 2019
* add focus meta with restrained invalidate

* change uses of focus to use local meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants