Slider: min / max value fix

[bitpshr]

Type: bug

The following has been addressed in the PR:

• There is a related issue
• All code matches the style guide
• Unit or Functional tests are included in the PR

Description:

This PR updates the Slider component so it never renders a value higher than its max or lower than its min.

Resolves #259

[codecov]

Codecov Report

Merging #262 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   98.78%   98.78%   +<.01%     
==========================================
  Files          24       24              
  Lines        1476     1478       +2     
  Branches      434      436       +2     
==========================================
+ Hits         1458     1460       +2     
  Partials       18       18

Impacted Files	Coverage Δ
src/slider/Slider.ts	98.27% <100%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551a3fd...d223e32. Read the comment docs.

[smhigley]

This isn't a suggestion so much as a question: my initial instinct is towards Math.max(value, min) and Math.min(value, max) for readability. Just curious if there's a rationale for one vs. the other apart from personal preference?

[tomdye]

I used the following previously (taken from npm/clamp).

function clamp(value, min, max) {
  return min < max
    ? (value < min ? min : value > max ? max : value)
    : (value < max ? max : value > min ? min : value)
}

[bitpshr]

@smhigley just preference. Even if I used Math.max and Math.min, I'd want to check that the value was actually greater than the max or less than the min before calling them, and at that point, I might as well just use the max and min directly to avoid unnecessary indirection of a Math method.

[smhigley]

cool :)