-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for themes #256
Add icons for themes #256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 24 24
Lines 1429 1429
Branches 413 413
=======================================
Hits 1414 1414
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks great.
Only thought is that we might want to include any font files under the |
Do you think the other themes will use Material icons too? If we think that will be pretty standard, I'm also in favor of moving them to |
I'm going to merge and close this PR. For now, let's leave the icons within the theme, and revisit when we have a second theme. |
Type: bug / feature
The following has been addressed in the PR:
Description:
Adds themed icons for the base theme, and updates the available icon classes in
src/common/styles
.