Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for themes #256

Merged
merged 2 commits into from
Jul 24, 2017
Merged

Add icons for themes #256

merged 2 commits into from
Jul 24, 2017

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Jul 18, 2017

Type: bug / feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Adds themed icons for the base theme, and updates the available icon classes in src/common/styles.

@smhigley smhigley requested review from bitpshr and tomdye July 18, 2017 19:17
@codecov
Copy link

codecov bot commented Jul 18, 2017

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          24       24           
  Lines        1429     1429           
  Branches      413      413           
=======================================
  Hits         1414     1414           
  Partials       15       15
Impacted Files Coverage Δ
src/combobox/ComboBox.ts 99.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f443f4...ac6583c. Read the comment docs.

Copy link
Member

@bitpshr bitpshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks great.

@tomdye
Copy link
Member

tomdye commented Jul 21, 2017

Only thought is that we might want to include any font files under the theme dir rather than limiting to the dojo theme, there will be others in the future.

@smhigley
Copy link
Contributor Author

Do you think the other themes will use Material icons too? If we think that will be pretty standard, I'm also in favor of moving them to /themes/fonts. I do also want to make sure it's easy to drop themes into projects. Will the CLI handle copying the correct theme css + fonts, so users won't need to remember they need themes/fonts in addition to e.g. themes/dojo?

@smhigley
Copy link
Contributor Author

I'm going to merge and close this PR. For now, let's leave the icons within the theme, and revisit when we have a second theme.

@smhigley smhigley merged commit 3ba28a5 into dojo:master Jul 24, 2017
@dylans dylans added this to the 2017.07 milestone Aug 9, 2017
@smhigley smhigley deleted the icon-update branch October 17, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants