Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module path for lookup in registry transformer #45

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 23, 2018

Type: bug

The following has been addressed in the PR:

Description:

The separator for module path should always be / regardless of the platform it is run on.

@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          17       17           
  Lines         506      506           
  Branches      121      121           
=======================================
  Hits          487      487           
  Misses          7        7           
  Partials       12       12
Impacted Files Coverage Δ
src/registry-transformer/index.ts 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d72a0...eb68196. Read the comment docs.

@agubler agubler force-pushed the fix-module-path-on-windows branch from 28ae7ac to 9381113 Compare March 23, 2018 15:17
@agubler agubler merged commit 049c1f0 into dojo:master Mar 23, 2018
@dylans dylans added this to the rc.2 milestone Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants