Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested transforms when resources are passed down through multiple widgets #880

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

agubler
Copy link
Member

@agubler agubler commented Feb 16, 2021

Type: feature

The following has been addressed in the PR:

Description:

Resource templates can be passed down through multiple widgets and as such should support multiple transforms required to get to and from the original data shape.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2c36720:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #880 (bba102f) into master (426bc82) will decrease coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
- Coverage   94.46%   94.44%   -0.02%     
==========================================
  Files         127      127              
  Lines        7999     8010      +11     
  Branches     1871     1872       +1     
==========================================
+ Hits         7556     7565       +9     
- Misses        443      445       +2     
Impacted Files Coverage Δ
src/core/middleware/resources.ts 94.27% <94.44%> (-0.10%) ⬇️
src/core/util.ts 98.00% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426bc82...2c36720. Read the comment docs.

@agubler agubler merged commit 9132d05 into dojo:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants