Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: onUpdate and onDetach APIs for dom pragma #829

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Aug 19, 2020

Type: feature

The following has been addressed in the PR:

Description:

Adds two new APIs for the dom pragma, onUpdate and onDetach that are called when the dom node is updated and removed respectively. This will enable support for integrations such as mounting a react component within a Dojo application.

Resolves #828

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a5ce18c:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #829 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         127      127           
  Lines        8034     8040    +6     
  Branches     1861     1864    +3     
=======================================
+ Hits         7845     7851    +6     
  Misses        189      189           
Impacted Files Coverage Δ
src/core/vdom.ts 98.07% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cf6b9...a5ce18c. Read the comment docs.

@agubler agubler merged commit a8606fb into dojo:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Additional onUpdate and onDetach APIs for the dom pragma
2 participants