Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error information on a test operation #44

Closed
agubler opened this issue Jul 30, 2018 · 0 comments
Closed

Improve error information on a test operation #44

agubler opened this issue Jul 30, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@agubler
Copy link
Member

agubler commented Jul 30, 2018

@kitsonk commented on Fri Dec 29 2017

Enhancement

In Stores, when attempting to apply an undo operation that is failing for some reason because the test operation does not pass, currently all you get is:

Error: Test operation failure. Unable to apply any operations.

An error message the provides more context would be more useful, like:

Error: Test operation failed.
    Expected "somevalue" for at path "/foo/bar/baz" but got "othervalue"

Potentially looking AssertionError and potentially moving that to core. The other advantage is it will utilise V8's diffing functionality when thrown, improving the information available in Chrome and Node.

@agubler agubler added the enhancement New feature or request label Jul 30, 2018
@devpaul devpaul self-assigned this Aug 16, 2018
devpaul added a commit to devpaul/framework that referenced this issue Aug 20, 2018
devpaul added a commit that referenced this issue Aug 28, 2018
* Adds helpful failure messages when a test operation fails. Resolves #44
* provide complete location in test failure message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants