[d3d8] Implement monotonic state block tokens #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
d3d8-tokens
branch
from
058d762
to
f1ef863
Compare
|
I've tested ~140 d3d8 games with this PR and everything checks out. I've only seen one obscure game (FireStarter), at times, passing a state block token to apply a previously deleted state block, which is why I added the validations. Native drivers on Windows XP don't do any validations and would outright crash in this situation. |
misyltoad
reviewed
Jul 9, 2024
misyltoad
reviewed
Jul 9, 2024
WinterSnowfall
force-pushed
the
d3d8-tokens
branch
from
f1ef863
to
8445d00
Compare
doitsujin
requested changes
Jul 9, 2024
misyltoad
reviewed
Jul 9, 2024
misyltoad
reviewed
Jul 9, 2024
WinterSnowfall
force-pushed
the
d3d8-tokens
branch
5 times, most recently
from
e1a3e66
to
623a8f4
Compare
|
Finalized now, hopefully. Thanks for all the nudging in the right directions. |
WinterSnowfall
force-pushed
the
d3d8-tokens
branch
from
623a8f4
to
cd6b9b3
Compare
|
Looks good to me. I don't have permission to merge so one of the maintainers will have to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would need feedback from @AlpyneDreams .
The idea is to get rid of reinterpret casts and stick with what native does, namely a monotonically increasing counter that is passed back as the token whenever new state blocks are created. Tests have shown there's no token reuse, not even between device resets.
I also don't think we should worry about the address space being exhausted, because I did some quick math and if let's say a game creates 8 state blocks per frame @ 60 fps, it will take about 100+ days to overflow a DWORD. That's "let's not worry about it" territory in my book... but I can in theory implement a check to see if a token is already taken before allocating it.