Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dxgi] Implement support for more formats in GetMonitorFormatBpp #3352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Etaash-mathamsetty
Copy link
Contributor

Reduces log spam in 3dmark fire strike
I don't know if it is any more useful than that lol

@doitsujin
Copy link
Owner

What is Firestrike doing exactly? None of this should be necessary since we already handle all legal swap chain formats.

@doitsujin
Copy link
Owner

Actually we're missing the RGB10A2 ones, but would still be good to know what the benchmark needs.

@Etaash-mathamsetty
Copy link
Contributor Author

Etaash-mathamsetty commented Apr 15, 2023

What is Firestrike doing exactly? None of this should be necessary since we already handle all legal swap chain formats.

Not sure, it just seems to be calling this function for the hell of it, it doesn't change anything related to how it runs or performs

If you want me to do further testing (like with a API trace, just tell me)

@doitsujin
Copy link
Owner

can you post a log?

@Etaash-mathamsetty
Copy link
Contributor Author

without patch:
steam-231350.log

with patch:
steam-231350.log

@Etaash-mathamsetty
Copy link
Contributor Author

@doitsujin I posted the logs, could you look at them?

@doitsujin
Copy link
Owner

I did look at them, for some reason it's querying everything somehow. Need to think about a more elegant way to improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants