Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d3d9] Convert window position relative to its parent. #1958

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[d3d9] Convert window position relative to its parent. #1958

merged 1 commit into from
Mar 3, 2021

Conversation

rbernon
Copy link
Contributor

@rbernon rbernon commented Mar 3, 2021

When using child windows, GetWindowRect is in screen coordinates while MoveWindow expects parent-relative position.

@doitsujin doitsujin requested a review from misyltoad March 3, 2021 15:07
misyltoad
misyltoad approved these changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@misyltoad misyltoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@misyltoad misyltoad merged commit 1589f51 into doitsujin:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misyltoad misyltoad misyltoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbernon @misyltoad