Report handlers via error handler instead of console#951
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves error reporting by routing errors to Sentry instead of logging them to the console. The changes replace console logging with calls to an error handler that can be configured via setErrorHandler().
Key Changes
- Added error capturing in the previously empty catch block when launching the runner
- Replaced console.error with errorHandler call when service worker registration fails
- Both error handlers now create Error objects with cause chaining for better error context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TomNaessens
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got some reports mentioning an alert cause by errors here. Instead of logging details in the console we should send them to sentry (which is handled on the Dodona side).
I checked for other uses of
console.logorconsole.error. There were no occurrences except for inLogging.ts, but that is not actually sent any error events. It's hard to get the error handler there, so I just left it as is.