Translate and style CodeMirror extensions#218
Merged
winniederidder merged 8 commits intomainfrom Jun 1, 2022
Merged
Conversation
pdawyndt
approved these changes
May 30, 2022
winniederidder
force-pushed
the
highlight-consumed-input
branch
from
fc42dcb to
fd9de12
Compare
winniederidder
force-pushed
the
translate-codemirror
branch
from
d9aae94 to
597cf2f
Compare
bmesuere
requested changes
May 31, 2022
Member
bmesuere
left a comment
bmesuere
left a comment
There was a problem hiding this comment.
I would capitalize all buttons since we already do that for the other buttons in papyros (and all other buttons on Dodona.
In addition, the style is only halfway there. There's a gradient background that is not present in the "neutral" copy-to-dodona button above.
winniederidder
force-pushed
the
highlight-consumed-input
branch
3 times, most recently
from
5cef67e to
78163e7
Compare
winniederidder
force-pushed
the
translate-codemirror
branch
from
597cf2f to
0805273
Compare
Contributor
Author
|
Just to be sure I understood you correctly. Do you want these buttons to also have the neutral color as is used on the Copy-button in Dodona? Example attached below: |
winniederidder
force-pushed
the
translate-codemirror
branch
from
3df4371 to
c3e73fc
Compare
winniederidder
force-pushed
the
translate-codemirror
branch
from
40ba5b6 to
7655b79
Compare
bmesuere
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for translating phrases used by CodeMirror. It also applies typical Papyros-styling to common elements generated by common extensions like search.
Example of the new search panel (open with Ctrl-F)
Closes #207