Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove running of non-existent sql file. Add volume for needed shell script #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shanedell
Copy link

Reasoning for PR

Issues addressed:

  1. File pop_mini_RE.sql was removed from gamerchanger-web in this commit. So it was removed from compose.
    • Should the file be added back into gamechanger-web instead?
  2. generateCombinedEnv.sh was not being copied into the container image for gamechanger-web and not volumed in. Added volume for the file in the docker-compose.
    • Should it instead be copied into the image via Dockerfile.prod in gamechanger-web?

Question

Should gamechanger-data's default branch be main instead of dev? dev seems to be 20 commits behind main. I can revert the repository url's and branches back to the original once (possibly changing dev to main for gamechanger-data) the other PRs are merged into the appropriate branches.

Accompanying PRs

@Segerlu
Copy link

Segerlu commented Jul 19, 2024

We are dealing with a potential spill of sensitive information and need this PR removed for now, I apologize for the inconvenience. Once this spill has been fixed we welcome you to resubmit your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants