Start babel 6 upgrade #218

tmcw · 2015-11-03T16:12:18Z

Fixes #211

Traversal with ast-types is broken because babel is departing from ESTree benjamn/ast-types#132

Going to test out babel's own traversal.

hzoo · 2015-11-06T16:33:48Z

lib/parsers/javascript.js

-    stage: 0,
-    locations: true,
-    ranges: true
+    presets: ['es2015', 'stage-0', 'react']


You only need to parse the ast correct? You can just use babylon for that and use the seperate babel-traverse package.

Example of what I did with babylon options: https://github.com/cst/cst/blob/master/src/Parser.js#L73-L94

jamiebuilds · 2015-11-09T01:17:29Z

You can use babel-types instead of this btw.

RobinQu · 2015-12-01T07:51:53Z

Hi, guys

What's status of this branch now?

Still failed to generate docs for babel@6 projects.

/Workspace/src/nodejs/documentation/bin/documentation.js:21
    throw err;
    ^

Error: did not recognize object of type "ObjectProperty"
    at Object.getFieldNames (/Workspace/src/nodejs/documentation/node_modules/ast-types/lib/types.js:659:15)
    at visitChildren (/Workspace/src/nodejs/documentation/node_modules/ast-types/lib/path-visitor.js:221:32)
    at Visitor.PVp.visitWithoutReset (/Workspace/src/nodejs/documentation/node_modules/ast-types/lib/path-visitor.js:202:16)
    at Visitor.PVp.visit (/Workspace/src/nodejs/documentation/node_modules/ast-types/lib/path-visitor.js:131:25)
    at Object.visit (/Workspace/src/nodejs/documentation/node_modules/ast-types/lib/path-visitor.js:99:51)
    at Object.inferName (/Workspace/src/nodejs/documentation/lib/infer/name.js:52:11)
    at /Workspace/src/nodejs/documentation/index.js:31:28
    at Array.map (native)
    at /Workspace/src/nodejs/documentation/index.js:94:16
    at /Workspace/src/nodejs/documentation/lib/input/dependency.js:42:5

tmcw · 2015-12-01T15:03:41Z

@RobinQu I got stuck on the previously-noted issue: benjamn/ast-types#132 - given that ast-types doesn't support everything Babel now outputs, and Babel's traversal is quite a bit different, this is more than a swap-in upgrade. I'll switch back onto this task after the --access flag is done, and possibly node v5 support.

tmcw · 2015-12-01T20:56:01Z

Just pushed some updates: now uses babylon, tries to use traverse. Any ideas from @hzoo @thejameskyle would be much appreciated; it doesn't seem like babylon or babel-traverse have any documentation and are pretty tricky to decipher.

hzoo · 2015-12-01T21:02:15Z

You can check https://github.com/babel/babel-eslint/blob/master/index.js#L372-L394 - the babylon options you are passing in are for v5.

Babylon has options in the readme https://github.com/babel/babel/tree/master/packages/babylon. You can also check out https://github.com/thejameskyle/babel-plugin-handbook#babylon

tmcw · 2015-12-01T21:02:30Z

lib/parsers/javascript.js


  var visited = {};

  function walkComments(ast, type, includeContext) {
-    types.visit(ast, {
-      visitNode: function (path) {
+    traverse(ast, {


Currently this throws with

Error: You must pass a scope and parentPath unless traversing a Program/File got a undefined node at traverse (/Users/tmcw/src/documentation/node_modules/babel-traverse/lib/index.js:55:13) at walkComments (/Users/tmcw/src/documentation/lib/parsers/javascript.js:47:5) at parseJavaScript (/Users/tmcw/src/documentation/lib/parsers/javascript.js:96:3)

tmcw · 2015-12-01T21:04:24Z

Parsing with babylon is working, but traversing the generated AST doesn't work and I can't find a simple example of using babel-traverse for doing so.

hzoo · 2015-12-01T21:07:06Z

lib/infer/kind.js

@@ -28,7 +28,7 @@ module.exports = function () {
      }
    }

-    types.visit(comment.context.ast, {
+    babel.traverse(comment.context.ast, {
      visitClassDeclaration: function () {


The traverse api uses the nodes as the keys like ClassDeclaration

{ visitor: { BinaryExpression(path) { // ... } } };```

tmcw · 2015-12-01T21:48:13Z

Trying to configure babelify with presets fails with

/Users/tmcw/src/documentation/bin/documentation.js:32
    throw err;
    ^

ReferenceError: Unknown plugin "es2015" specified in "base" at 0, attempted to resolve relative to "/Users/tmcw/src/documentation/test/fixture" while parsing file: /Users/tmcw/src/documentation/test/fixture/es6.input.js
    at /Users/tmcw/src/documentation/node_modules/babel-core/lib/transformation/file/options/option-manager.js:193:17
    at Array.map (native)
    at Function.normalisePlugins (/Users/tmcw/src/documentation/node_modules/babel-core/lib/transformation/file/options/option-manager.js:173:20)
    at OptionManager.mergeOptions (/Users/tmcw/src/documentation/node_modules/babel-core/lib/transformation/file/options/option-manager.js:271:36)
    at OptionManager.init (/Users/tmcw/src/documentation/node_modules/babel-core/lib/transformation/file/options/option-manager.js:416:10)
    at File.initOptions (/Users/tmcw/src/documentation/node_modules/babel-core/lib/transformation/file/index.js:190:75)
    at new File (/Users/tmcw/src/documentation/node_modules/babel-core/lib/transformation/file/index.js:121:22)
    at Pipeline.transform (/Users/tmcw/src/documentation/node_modules/babel-core/lib/transformation/pipeline.js:42:16)
    at Babelify._flush (/Users/tmcw/src/documentation/node_modules/babelify/index.js:28:24)
    at Babelify.<anonymous> (_stream_transform.js:118:12)

No notes about a relative dir in the babelify readme.

hzoo · 2015-12-01T22:01:51Z

lib/input/dependency.js

@@ -26,7 +26,7 @@ function dependencyStream(indexes, options, callback) {
    },
    transform: [babelify.configure({
      sourceMap: false,
-      stage: 0
+      plugins: ['es2015', 'stage-0', 'react']


presets here

tmcw · 2015-12-02T15:26:39Z

Upstream issue for enter() method: https://phabricator.babeljs.io/T6740

jamiebuilds · 2015-12-03T03:32:40Z

lib/infer/kind.js

-      visitTypeAlias: function () {
+      FunctionDeclaration: visitFunction,
+      FunctionExpression: visitFunction,
+      ArrowFunctionExpression: visitFunction,


If you want you can also visit any node with the Function alias including ClassMethod and ObjectMethod (in addition to what you have)

tmcw · 2015-12-06T22:40:38Z

Upstream for failure to use deepEqual: https://phabricator.babeljs.io/T6775?workflow=create#R - removeProperties does not provide a JSON-serializable output.

tmcw · 2016-01-24T16:38:43Z

Going to give this a second try now that we use traversal less.

hzoo reviewed Nov 6, 2015
View reviewed changes

tmcw added 2 commits December 1, 2015 15:43

Start babel 6 upgrade

de0c3c7

Continue switching to babel 6

2be7862

tmcw force-pushed the babel-6 branch from 85be602 to 2be7862 Compare December 1, 2015 20:43

Use babylon

5d55a8e

remove deprecated presets

12800d5

tmcw reviewed Dec 1, 2015
View reviewed changes

hzoo reviewed Dec 1, 2015
View reviewed changes

tmcw added 6 commits December 1, 2015 16:10

Fix parse redefintion

cb1b916

Fix traverse syntax

e56bb32

Switch more to babel-types and babel-traverse [skip ci]

d8a3cc7

Try to port kind and params inference

72f5a9c

Try to use babel 6 options.

dc4ae61

Reintroduce presets because module-deps needs them.

81c3514

tmcw mentioned this pull request Dec 1, 2015

Plugin lookup path babel/babelify#159

Closed

hzoo reviewed Dec 1, 2015
View reviewed changes

tmcw added 2 commits December 1, 2015 17:10

s/plugins/presets, thanks @hzoo

d72eb59

Port more ast-types code to babel-traverse

3747304

tmcw added 3 commits December 2, 2015 13:19

Update inference to use #traverse

556d89a

Fix flow_doctrine tests

aa03c2b

Fix name inference tests

0e52709

jamiebuilds reviewed Dec 3, 2015
View reviewed changes

tmcw added 4 commits December 3, 2015 15:24

Use babel-types

afeacba

Fix last membership bugs

246eb81

Fix code snippet extraction in JavaScript parser

0f82195

Fix circular references, fix inferencers

4acd658

tmcw mentioned this pull request Dec 18, 2015

Update to babel 6 #211

Closed

tmcw closed this Jan 24, 2016

tmcw deleted the babel-6 branch January 24, 2016 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start babel 6 upgrade #218

Start babel 6 upgrade #218

tmcw commented Nov 3, 2015

hzoo Nov 6, 2015

jamiebuilds commented Nov 9, 2015

RobinQu commented Dec 1, 2015

tmcw commented Dec 1, 2015

tmcw commented Dec 1, 2015

hzoo commented Dec 1, 2015

tmcw Dec 1, 2015

tmcw commented Dec 1, 2015

hzoo Dec 1, 2015

tmcw commented Dec 1, 2015

hzoo Dec 1, 2015

tmcw commented Dec 2, 2015

jamiebuilds Dec 3, 2015

tmcw commented Dec 6, 2015

tmcw commented Jan 24, 2016

Start babel 6 upgrade #218

Start babel 6 upgrade #218

Conversation

tmcw commented Nov 3, 2015

hzoo Nov 6, 2015

Choose a reason for hiding this comment

jamiebuilds commented Nov 9, 2015

RobinQu commented Dec 1, 2015

tmcw commented Dec 1, 2015

tmcw commented Dec 1, 2015

hzoo commented Dec 1, 2015

tmcw Dec 1, 2015

Choose a reason for hiding this comment

tmcw commented Dec 1, 2015

hzoo Dec 1, 2015

Choose a reason for hiding this comment

tmcw commented Dec 1, 2015

hzoo Dec 1, 2015

Choose a reason for hiding this comment

tmcw commented Dec 2, 2015

jamiebuilds Dec 3, 2015

Choose a reason for hiding this comment

tmcw commented Dec 6, 2015

tmcw commented Jan 24, 2016