Improve tokenizer regex matching #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-2.5% improved runtime
-63% improved runtime
-4% improved runtime
greg0ire
reviewed
Jun 12, 2024
greg0ire
reviewed
Jun 12, 2024
greg0ire
reviewed
Jun 12, 2024
mvorisek
force-pushed
the
fix_perf2
branch
2 times, most recently
from
236b6e5
to
fda3d6e
Compare
greg0ire
approved these changes
Jun 18, 2024
|
I would be happy if this PR can be merged so I can work on follow up PRs. |
SenseException
approved these changes
Jun 21, 2024
|
Thanks @mvorisek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #119 as requested
Total runtime reduction is about -70%.