Add support for Oracle LOOP statement

[mvorisek]

docs: https://docs.oracle.com/en/database/oracle/oracle-database/19/lnpls/basic-LOOP-statement.html

[greg0ire]

Fix fatal error for Oracle LOOP statement

What fatal error are you talking about?

[mvorisek]

Doctrine\SqlFormatter\Tests\SqlFormatterTest::testFormat with data set #51 ('BEGIN\n  FOR i IN 1..5\n  LOO...\nEND;', 'BEGIN\n  FOR i IN 1..5 LOOP\n...\nEND;')
ValueError: str_repeat(): Argument #2 ($times) must be greater than or equal to 0

...\src\SqlFormatter.php:87
...\src\SqlFormatter.php:292
...\tests\SqlFormatterTest.php:47

(when the tests are run /wo the fix)

[greg0ire]

Apparently, situations where the indent level ends up being negative are supposed to be handled by highlighting the last token in red:

sql-formatter/src/SqlFormatter.php

Lines 217 to 223 in 51e2d67

	if ($indentLevel < 0) {
	// This is an error
	$indentLevel = 0;
	$return .= $this->highlighter->highlightError($token->value());
	continue;
	}

Should we address that first?

[mvorisek]

Apparently, situations where the indent level ends up being negative are supposed to be handled by ...

Should we address that first?

Any warning added to a query is unwanted - it corrupts the query, so yes, this should be addressed, but for 1.4.x by parsing the tokens into matched indentation blocks. If the tokens are unable to be matched (like something is opened but not closed and vice versa), this should be in no indentation, but without any error/warning added to the formatted query.

This PR fixes known LOOP not opening an indentation block but END closing it. Even with the fix discussed above, we need this PR to format such SQL properly. So it is safe to land this PR now as needed anyway.

[greg0ire]

OK so:

• there is a bug, and you are not fixing it here
• support for LOOP is missing, and that is what you are contributing here (so it's a new feature, and you are targeting 1.5.x), and it happens to make a crash disappear, but the same crash can happen in many other situations.

Please rework your commit message to make it more apparent that this is not a fix.

[mvorisek]

For the general issue you mentioned I created #118 👍