Show more details about errors in PHPUnit

[GromNaN]

Extracted from #450 (comment)

[greg0ire]

Regarding displayDetailsOnTestsThatTriggerErrors: what's the difference between having it and the default behavior?

[greg0ire]

@GromNaN I tried throw \Error inside a test, and couldn't find a difference with or without this setting, so let's remove it?

[GromNaN]

The different is with trigger_error('Hello World', E_USER_ERROR).

  PHPUnit 12.4.1 by Sebastian Bergmann and contributors.
  
  Runtime:       PHP 8.4.8
  Configuration: /Users/jerome/Develop/doctrine-persistence/phpunit.xml.dist

  E                                                                   1 / 1 (100%)

  Time: 00:00.006, Memory: 16.00 MB

  There was 1 error:
  
  1) ErrorTest::testError
  E_USER_ERROR was triggered
  tests/ErrorTest.php:9

+ --
+ 
+ 1 test triggered 1 error:
+ 
+ 1) tests/ErrorTest.php:9
+ Hello World
+
  ERRORS!
  Tests: 1, Assertions: 0, Errors: 2, Deprecations: 1.

[greg0ire]

Ah nice! I guess it could be useful to have the "Hello World" part.

[GromNaN]

This was my test:

<?php

use PHPUnit\Framework\TestCase;

class ErrorTest extends TestCase
{
    public function testError(): void
    {
        trigger_error('Hello World', E_USER_ERROR);
    }
}

[GromNaN]

We get deprecation with PHP 8.1, without message

PHPUnit 10.5.58 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.33 with PCOV 1.0.12
Configuration: /home/runner/work/persistence/persistence/phpunit.xml.dist

...................................................DS..........  63 / 137 ( 45%)
............................................................... 126 / 137 ( 91%)
...........                                                     137 / 137 (100%)

Time: 00:00.258, Memory: 22.00 MB

OK, but there were issues!
Tests: 137, Assertions: 249, Deprecations: 10, Skipped: 1.

Generating code coverage report in Clover XML format ... done [00:00.020]

[xabbuh]

When the job uses lowest dependencies, PHPUnit should probably be instructed to not fail when detecting deprecations using the --do-not-fail-on-deprecation flag.

[GromNaN]

I updated the Action. PR is ready.

[greg0ire]

👌