fix: attribute association override default values not set for joinColumns and inverseJoinColumns if joinTable is set for a many-to-many association

[alanpoulain]

This PR fixes a bug when an attribute association override is used for a many-to-many association with only a join table set.
In this case, joinColumns and inverseJoinColumns will be set to an empty array:

orm/lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php

Lines 487 to 488 in f79ec43

	'joinColumns' => $override['joinColumns'] ?? [],
	'inverseJoinColumns' => $override['inverseJoinColumns'] ?? [],

Later on, in the method _validateAndCompleteManyToManyMapping, default values will not be set and the empty arrays will be kept because of isset:

orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

Lines 2056 to 2064 in f79ec43

	if (! isset($mapping['joinTable']['joinColumns'])) {
	$mapping['joinTable']['joinColumns'] = [
	[
	'name' => $this->namingStrategy->joinKeyColumnName($mapping['sourceEntity'], $selfReferencingEntityWithoutJoinColumns ? 'source' : null),
	'referencedColumnName' => $this->namingStrategy->referenceColumnName(),
	'onDelete' => 'CASCADE',
	],
	];
	}

The first commit adds a failing test. You can see that the configuration works for all the mappings (PHP, XML, annotations...) excepted the attribute mapping.
The second commit fixes it by using null instead of empty arrays.

Related PR (introducing the bug): #9241
@beberlei if you can have a look at this PR since you wrote the code 🙂

[greg0ire]

You can use vendor/bin/phpcbf to fix many of the cs issues.

[greg0ire]

Sorry didn't mean to close 😅

[alanpoulain]

Thanks for the quick review @greg0ire! 🙂

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[github-actions]

This pull request was closed due to inactivity.