Use a specific configuration file for DBAL 2 #9343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like for PHPStan, we now have 2 configuration files with common ignore rules. This should make it easier to update the baseline.
Member
Author
|
Looks like this isn't working… no merge seems to be happening (I've experimenting doing the include after defining the rules, and everything defined in issue-handlers.xml was ignored. |
Member
Author
|
Because of this discussion, I now think our best bet is to just run Psalm once. PHPStan covering the DBAL 2 should be enough IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like for PHPStan, we now have 2 configuration files with common
ignore rules. This should make it easier to update the baseline.
Follow-up of #9336