Skip to content

Phpunit 8 #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
beberlei merged 3 commits into from
Nov 7, 2020
Merged

Phpunit 8 #8330

beberlei merged 3 commits into from
Nov 7, 2020

Conversation

@greg0ire
Copy link
Member

@greg0ire greg0ire commented Nov 7, 2020

No description provided.

@greg0ire greg0ire force-pushed the phpunit-8 branch 6 times, most recently from cfa9e5d to 7983805 Compare November 7, 2020 17:40
@beberlei
Copy link
Member

beberlei commented Nov 7, 2020

@greg0ire i did this work in #8303 already, should we spit that up?

@greg0ire greg0ire force-pushed the phpunit-8 branch 4 times, most recently from 4bc5783 to 25ca1af Compare November 7, 2020 17:59
@greg0ire
Copy link
Member Author

greg0ire commented Nov 7, 2020

@greg0ire i did this work in #8303 already, should we spit that up?

Argh, I didn't see… well, I'm almost done I think.

beberlei
beberlei previously approved these changes Nov 7, 2020
View reviewed changes
@greg0ire
Revert to whitelist
7f670c5 
coverage requires PHPunit 9, and we don't have that yet.
@greg0ire
Upgrade to PHPUnit 8
3e9a8b8 
This unlocks PCOV usage for coverage
@greg0ire
Upload coverage files to Codecov
a926f62
@greg0ire
Copy link
Member Author

greg0ire commented Nov 7, 2020

I had to push again @beberlei , the filter path missed a ../, now coverage is generated properly and should be uploaded to Codecov 🤞

@greg0ire greg0ire marked this pull request as ready for review November 7, 2020 18:14
@greg0ire greg0ire requested a review from beberlei November 7, 2020 18:17
@beberlei beberlei merged commit 385b5a2 into doctrine:2.7 Nov 7, 2020
@greg0ire greg0ire deleted the phpunit-8 branch November 7, 2020 18:49
@beberlei beberlei mentioned this pull request Nov 8, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beberlei beberlei beberlei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@greg0ire @beberlei