Skip to content

Add missing assertion in test #12135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg0ire merged 1 commit into from
Aug 17, 2025
Merged

Add missing assertion in test #12135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/Tests/ORM/Mapping/OneToOneOwningSideMappingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Doctrine\Tests\ORM\Mapping;

use Doctrine\Deprecations\PHPUnit\VerifyDeprecations;
use Doctrine\ORM\Mapping\DefaultNamingStrategy;
use Doctrine\ORM\Mapping\JoinColumnMapping;
use Doctrine\ORM\Mapping\OneToOneOwningSideMapping;
Expand All @@ -17,6 +18,8 @@

final class OneToOneOwningSideMappingTest extends TestCase
{
use VerifyDeprecations;

public function testItSurvivesSerialization(): void
{
$mapping = new OneToOneOwningSideMapping(
Expand Down Expand Up @@ -48,6 +51,15 @@ public function testNullableDefaults(
array $mappingArray,
): void {
$namingStrategy = new DefaultNamingStrategy();
if ($expectDeprecation) {
$this->expectDeprecationWithIdentifier(
'https://github/doctrine/orm/pull/12125',
);
} else {
$this->expectNoDeprecationWithIdentifier(
'https://github/doctrine/orm/pull/12125',
);
}

$mapping = OneToOneOwningSideMapping::fromMappingArrayAndName(
$mappingArray,
Expand Down