QueryBuilder: prevent misuse of DELETE with LIMIT

[janedbal]

Imagine you want to delete just last entry, but all your rows disappear:

$this->entityManager->createQueryBuilder()
            ->delete(MyEntity::class, 'e')
            ->orderBy('e.createdAt', 'ASC')
            ->setMaxResults(1); // limit ignored silently

I believe Doctrine should protect developers from doing destructive operations by not silently omitting crucial part of query builder (LIMIT, although named setMaxResults).

[greg0ire]

Thanks @janedbal !