Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore deprecations from doctrine/common #11793

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Ignore deprecations from doctrine/common #11793

merged 1 commit into from
Jan 18, 2025

Conversation

greg0ire
Copy link
Member

These new issues are caused by doctrine/common 3.5.0, released 2 weeks ago.

@greg0ire
Ignore deprecations from doctrine/common
44d5d4a 
These new issues are caused by doctrine/common 3.5.0, released 2 weeks
ago.
@greg0ire greg0ire force-pushed the doctrine-common-support branch from dc846f7 to 44d5d4a Compare January 17, 2025 07:33
@greg0ire
Copy link
Member Author

Note: at first, I had tried doing the ignore in a cleaner way, using phpstan.neon + PHPStan identifiers, but in the CI, it worked only for the "(default, default)" job. I guess both other jobs have some dependency crucial to the ignore with identifiers working in a version that is too low.

@greg0ire greg0ire mentioned this pull request Jan 17, 2025
Merged
@greg0ire greg0ire merged commit c12fd2c into doctrine:2.20.x Jan 18, 2025
3 checks passed
@greg0ire greg0ire added this to the 2.20.2 milestone Jan 18, 2025
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
2.20.2
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @SenseException