Skip to content

Support Type::convertToPHPValueSQL in ResultSetMappingBuilder #7809

@Elemecca

Description

@Elemecca

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

As of #198 entity persistence supports DBAL's Type::convertToPHPValueSQL method, which can be used to wrap columns in an SQL expression in the select clause of the generated query. However ResultSetMappingBuilder::generateSelectClause was not updated, so when using native queries with ResultSetMappingBuilder the convertToPHPValueSQL method is not applied to the generated select clause. I think it should be.

This looks like a pretty simple thing to implement and I'm happy to submit a PR. I think this is a simple enough non-breaking change that it could target the 2.6 branch, but before I start work I wanted to make sure that the change is acceptable and which branch I need to target.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions