DDC-2838: Leaky abstraction when applying Criteria to hydrated/non-hydrated PersistentCollection

[doctrinebot]

Jira issue originally created by user ptlis:

When applying a Criteria to a PersistentCollection that has been hydrated the field names must be camel case, if the collection has not yet been hydrated the field names must be underscore separated.

The github repo linked here contains a simplified testcase for the matrix of hydrated/non-hydrated entities and camel case/underscore separated fields.

https://github.com/ptlis/DoctrineTestcase

[doctrinebot]

• is referenced by DCOM-275: Collections\Expr\ClosureExpressionVisitor should support private properties as well as SQL visitors do.
• is referenced by DCOM-249: Criteria are unable to locate getters for properties with an underscore prefix

[doctrinebot]

Comment created by @Ocramius:

We can't check out an entire project just to test a bug.

Please write an actual functional test case that can be integrated into the Doctrine ORM test suite.

[doctrinebot]

Comment created by ptlis:

Hi,

i'm happy to do so - i'll take a look at this over the weekend.

[doctrinebot]

Comment created by derula:

[~ptlis]: Any progress on this? This is currently an issue for us as well and hope to get fixed. I could look into converting it to a test for integration with the test suite if you don't have the time... but it might take a while since I have no experience with the requirements that should be met. (Plus, I am not sure how tightly coupled it is with your project)

[doctrinebot]

Comment created by derula:

Hi [_{ocramius], [}ptlis],

I attached a functional Test that integrates with the test suite. Please let me know if I should issue a PR, and I'll do that this evening.

[doctrinebot]

Comment created by floeh:

+1

[doctrinebot]

Comment created by derula:

My idea to solve this would go like this:

• Add a new class ObjectCollection in Common that implements Collection and Selectable, but requires class metadata.
• Whenever creating an ArrayCollection with entities / other objects, create an ObjectCollection instead.

The only thing that's causing me a headache is that ideally, there should be code sharing in some form between the matching() implementations of ObjectCollection and PersistentCollection, because both will use class metadata. Maybe this can be achieved somehow using a trait?

If you like the idea, I could look into it further.

[ostrolucky]

I tried this and it seems to be no longer reproducible with provided demo repository. @ptlis can you confirm?

[ostrolucky]

This has been fixed via doctrine/collections@32d5245 you can close this guys @Ocramius

[alcaeus]

Thanks @ostrolucky!