This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Corrected fluent interface docblocks #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`self` means the base class will always be returned. This is not only false, but breaks code completion in some editors when attempting to access derived class methods. For more information see [phpDocumentor types documentation](https://www.phpdoc.org/docs/latest/guides/types.html#keywords).
|
Keeping it open for a moment so we remember to change other places, thanks @Bilge for getting started! |
|
Thanks for getting us started on this, I replaced the remaining occurrences of |
|
@alcaeus Oh, really? I was just in the middle of doing the same. Did you do it for ODM as well or shall I? |
|
Apparently, I missed the announcement that you were doing the remaining changes as well - I apologize for that. Go ahead and finish up the ODM pull request. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfmeans the base class will always be returned. This is not only false, but breaks code completion in some editors when attempting to access derived class methods. For more information see phpDocumentor types documentation.