This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Bump doctrine/common dependency #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
added a commit
that referenced
this pull request
Feb 24, 2015
Bump doctrine/common dependency
| @@ -1,5 +1,2 @@ | |||
| phpunit.xml | |||
| vendor | |||
| composer.lock | |||
There was a problem hiding this comment.
why commiting the lock file in the library ?
There was a problem hiding this comment.
I talked with @naderman about this at FOSDEM. It's ignored for projects that depend on ODM, so it doesn't affect our users, but it gives developers consistency for reproducing test results (also the "build status" icon).
|
Commiting the lock file will force dependencies to be locked for that specific version. |
|
Composer does not consider the content of a dependency's lock file, only the lock file in the root project itself is ever used. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.