Skip to content
This repository has been archived by the owner on Nov 11, 2020. It is now read-only.

Allow string or array Cursor::hint() argument #159

Closed
wants to merge 1 commit into from

Conversation

Gnucki
Copy link
Contributor

@Gnucki Gnucki commented Mar 25, 2014

Wait for a string or an array but force an array in the signature of the method.

http://php.net/manual/en/mongocursor.hint.php

@jmikola jmikola changed the title Allow hint by index name (BUG) Allow string or array Cursor::hint() argument Mar 27, 2014
@jmikola jmikola added this to the 1.0.6 milestone Mar 27, 2014
jmikola added a commit that referenced this pull request Mar 27, 2014
@jmikola
Copy link
Member

jmikola commented Mar 27, 2014

Manually merged to the 1.0.x branch in 42fca10. Thanks for the contribution.

@jmikola jmikola closed this Mar 27, 2014
@kchevalier-mg
Copy link

This update breaks the ODM Cursor declaration Doctrine\ODM\MongoDB\Cursor::hint() at line 303 - need to remove the array hint from there too.

@Gnucki
Copy link
Contributor Author

Gnucki commented Mar 28, 2014

I did a pull request for that too.

@jmikola
Copy link
Member

jmikola commented Mar 28, 2014

Fixing in #163.

See my comment in doctrine/mongodb-odm#824.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants