This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Query builder read prefs and wrap driver classes directly #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Constructor signatures have changed. Collections and Databases are now constructed with the MongoCollection and MongoDB instances to be wrapped, respectively. The getter methods for driver classes no longer operate like factories (returning new instances on each call), which makes it possible to set and maintain read preferences. The ability to reconstruct MongoClient has been removed from Cursor::retry() and Connection::initialize(), since that is not necessary for the driver to reestablish a database connection. For the Loggable classes, the loggerCallable argument has been moved to the end of the constructor. This removes previous inconsistencies between Loggable and non-Loggable constructors.
MongoCursor::setReadPreference() is not affected, since its method wasn't implemented until 1.3.3.
The driver may emit an E_WARNING for invalid arguments, but the return value should always be the MongoCursor (not a boolean). Move the saving of readPreference and tags arguments after the driver method, so that we don't capture the arguments if an error handler decides to throw an exception. See: https://jira.mongodb.org/browse/PHP-920
Read preferences will be applied during cursor preparation. For read-only commands, the read preference will be temporarily applied to the database (most cases) or collection and then restored before the command's result is returned or its exception propagated.
jmikola
added a commit
that referenced
this pull request
Nov 1, 2013
Query builder read prefs and wrap driver classes directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is comprehensive change to properly support read preferences.
Database and Collection are now constructed with corresponding driver classes, which they wrap permanently. The getter methods no longer act like factory methods, which means it's possible for settings such as read preferences to be assigned and stay in place.
Constructor signatures for core classes (excluding Connection) changed a bit, but there should not be BC breaks for public methods.