This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Events refactoring and support for modifying data in EventArgs #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function __construct($invoker, $data = null, array $options = array()) | ||
| { | ||
| parent::__construct($invoker, $data, $options); | ||
| $this->isDataChanged = false; |
There was a problem hiding this comment.
you could use private $isDataChanged = false, thus avoiding to overwrite the constructor.
|
Cool exactly what i needed 👍 |
Both call patterns are supported in Database::createCollection(). CreateCollectionEventArgs is also modified, although the original methods are left in place and deprecated.
This adds options fields to events where appropriate, with a default value to preserve BC.
With the addition of FindEventArgs, find events will not receive the field projection in addition to the query. UpdateEventArgs now has options. A new MutableEventArgs class was created to allow Collection query/command results to be modified by the post event listeners (as requested in #94). Finally, CollectionEventsTest was created to test all pre/post events dispatched by Collection methods.
|
@stof: Thanks for the suggestion. @henrikbjorn: Good to hear. |
jmikola
added a commit
that referenced
this pull request
May 30, 2013
Events refactoring and support for modifying data in EventArgs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #98 and fixes #94.