[3.x] Remove chained method Stage::search() as the $search stage must be the first of the pipeline#2929
Merged
GromNaN merged 1 commit intodoctrine:3.0.xfrom Dec 2, 2025
Merged
Conversation
Member
GromNaN
commented
Nov 24, 2025
GromNaN
commented
| Q | A |
|---|---|
| Type | improvement |
| BC Break | yes |
| Fixed issues | #2823 |
GromNaN
changed the title
Stage::search() as the $search stage must be firstStage::search() as the $search stage must be the first of the pipeline
GromNaN
force-pushed
the
3-stage-search
branch
from
3f0ed04 to
5ea3503
Compare
IonBazan
changed the title
Stage::search() as the $search stage must be the first of the pipelineStage::search() as the $search stage must be the first of the pipeline
There was a problem hiding this comment.
Pull request overview
This PR removes a deprecated chained method Stage::search() from the aggregation pipeline API, enforcing that the $search stage must be the first stage in a MongoDB aggregation pipeline by only allowing its use through Builder::search().
Key changes:
- Removed the deprecated
Stage::search()method that allowed incorrectly chaining the$searchstage - Removed the unused
trigger_deprecationimport
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alcaeus
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.