Fix "Cannot use object of type stdClass as array" in search index drop

[GromNaN]

Q	A
Type	bug
BC Break	no
Fixed issues	fix #2684

Summary

The typeMap option from the Collection instance is not inherited (bug report PHPLIB-1548).

This was not detected by unit tests as the call to Collection::listSearchIndexes() is mocked.

mongodb-odm/tests/Doctrine/ODM/MongoDB/Tests/SchemaManagerTest.php

Lines 444 to 454 in ff90e9a

	public function testUpdateDocumentSearchIndexes(): void
	{
	$collectionName = $this->dm->getClassMetadata(CmsArticle::class)->getCollection();
	$collection = $this->documentCollections[$collectionName];
	$collection
	->expects($this->once())
	->method('listSearchIndexes')
	->willReturn(new ArrayIterator([
	['name' => 'default'],
	['name' => 'foo'],
	]));

[alcaeus]

Change LGTM, but we should add a note that we can drop this once we bump the version requirement to the version that fixes this.

[alcaeus]

Note: the PHPStan errors suggest that we need to change the @param annotation for listSearchIndexes as well - it should read {name?: string, ...} to allow extra elements in the options array.

[GromNaN]

Note: the PHPStan errors suggest that we need to change the @param annotation for listSearchIndexes as well - it should read {name?: string, ...} to allow extra elements in the options array.

Done in mongodb/mongo-php-library#1480. I'll add this to the baseline for the time being.

Surprisingly, phpstan doesn't care.