Merged
Conversation
goetas
force-pushed
the
version-comparator
branch
from
4a9ccd3 to
48cbbd8
Compare
greg0ire
reviewed
Jan 13, 2020
Member
|
@pulzarraider please review |
greg0ire
approved these changes
Jan 14, 2020
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
goetas
force-pushed
the
version-comparator
branch
from
4c635ab to
937378c
Compare
Member
Author
|
@pulzarraider I'm merging this in order to be able to continue to work on #908 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #902
Summary
This is an alternative implementation to #902
The main change is that now the comparing function does not receive instances of
AvailableMigrationbutVersion. This change is needed if we want to be able to sort executed unavailable migrations. Being able to sort unavailable migrations is important to allow to implement properly #908 by offering all the migrations in a single table instead of two separate.