Merged
Conversation
Contributor
carusogabriel
commented
Dec 27, 2019
carusogabriel
commented
| Q | A |
|---|---|
| Type | improvement |
| BC Break | no |
| Fixed issues | - |
carusogabriel
commented
Dec 27, 2019
lib/Doctrine/Migrations/Tools/Console/Command/DoctrineCommand.php
Outdated
Show resolved
Hide resolved
goetas
approved these changes
Dec 28, 2019
Member
|
Not sure if makes sense to have this also for the 2.x branch? |
goetas
requested changes
Dec 29, 2019
Member
goetas
left a comment
goetas
left a comment
There was a problem hiding this comment.
Requesting changes to avoid accidental merges.
Member
|
@carusogabriel shouldn't doctrine/coding-standard v7 be PSR-12 compatible? |
Contributor
Author
|
@goetas Please see doctrine/coding-standard#148, we're voting it to v8. |
Contributor
Author
If the branch 2.x is just receiving bug fixes and security patches, I don't think is necessary. |
Contributor
Author
|
@goetas Good to go, or should we rebase it with |
Member
|
I would like to wait for #898. Would like to avoid useless conflict resolution created by an automatic tool. Is it ok for you? |
goetas
force-pushed
the
dependencies/doctrine-coding-standard-v7
branch
from
dc713d5 to
6d1bf4c
Compare
goetas
approved these changes
Jan 14, 2020
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.