Merged
Conversation
lcobucci
suggested changes
Nov 11, 2018
Member
lcobucci
left a comment
lcobucci
left a comment
There was a problem hiding this comment.
Some small things, nice job 👍
lcobucci
reviewed
Dec 5, 2018
|
|
||
| /** | ||
| * @return Connection|Configuration[] | ||
| * @return object[] [Connection, Configuration] |
Member
There was a problem hiding this comment.
Is this correct? Didn't see this syntax before 😛
Contributor
There was a problem hiding this comment.
Yeah, looks weird, imho has no meaning in PHPStan context.
Member
Author
Member
Author
There was a problem hiding this comment.
I think it should be this:
@return Connection[]|Configuration[]
Contributor
There was a problem hiding this comment.
Afaik it was intended to indicate a tuple consisting of Connection and Configuration, not array of those.
Member
Author
There was a problem hiding this comment.
phpstan didn't complain about the syntax. Should I change it back?
lcobucci
approved these changes
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Also enabling PHPStan in tests/ on L7 + strict.