Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tables rendering in configuration.rst #1459

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Zayon
Copy link
Contributor

@Zayon Zayon commented Sep 10, 2024

Q A
Type improvement
BC Break no
Fixed issues

Summary

Fixes content that was cropped in table in the configuration documentation

image

The table is currently rendered in html as :

<table>
            <thead>
                            <tr>
                                            <th>Name</th>
                                            <th>Required</th>
                                            <th>Default</th>
                                            <th>Description</th>
                                    </tr>
                    </thead>
        <tbody>
                    <tr>
                                    <td colspan="3">migrations_paths&lt;string, string&gt;        null</td>
                                    <td>The PHP namespace your migration classes are located under and the path to a dire</td>
                            </tr>
                    <tr>
                                    <td>table_storage</td>
                                    <td>no</td>
                                    <td>&nbsp;</td>
                                    <td>Used by doctrine migrations to track the currently executed migrations</td>
                            </tr>
                    <tr>
                                    <td>all_or_nothing</td>
                                    <td>no</td>
                                    <td>false</td>
                                    <td>Whether or not to wrap multiple migrations in a single transaction.</td>
                            </tr>
                    <tr>
                                    <td>transactional</td>
                                    <td>no</td>
                                    <td>true</td>
                                    <td>Whether or not to wrap migrations in a single transaction.</td>
                            </tr>
                    <tr>
                                    <td>migrations</td>
                                    <td>no</td>
                                    <td>[]</td>
                                    <td>Manually specify the array of migration versions instead of finding migrations.</td>
                            </tr>
                    <tr>
                                    <td>check_database_platform</td>
                                    <td>no</td>
                                    <td>true</td>
                                    <td>Whether to add a database platform check at the beginning of the generated code.</td>
                            </tr>
                    <tr>
                                    <td>organize_migrations</td>
                                    <td>no</td>
                                    <td><code>none</code></td>
                                    <td>Whether to organize migration classes under year (<code>year</code>) or year and month (``</td>
                            </tr>
                    <tr>
                                    <td>connection</td>
                                    <td>no</td>
                                    <td>null</td>
                                    <td>The named connection to use (available only when ConnectionRegistryConnection is</td>
                            </tr>
                    <tr>
                                    <td>em</td>
                                    <td>no</td>
                                    <td>null</td>
                                    <td>The named entity manager to use (available only when ManagerRegistryEntityManager</td>
                            </tr>
            </tbody>
</table>

@SenseException
Copy link
Member

👍

Please squash your two commits into one.

@Zayon
Copy link
Contributor Author

Zayon commented Sep 13, 2024

Done ✅

@SenseException
Copy link
Member

Thank you @Zayon

@SenseException SenseException merged commit 45f0a60 into doctrine:3.8.x Sep 13, 2024
1 check passed
@greg0ire greg0ire added this to the 3.8.2 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants