Assert there is no failure #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern is not dynamic, and we know it works. This addresses an issue reported by PHPStan.
SenseException
approved these changes
Aug 27, 2024
derrabus
reviewed
Aug 28, 2024
| if (preg_match('~(.*)\\\\([^\\\\]+)~', $fqcn, $mch) === 0) { | ||
| $mch = []; | ||
| $matchResult = preg_match('~(.*)\\\\([^\\\\]+)~', $fqcn, $mch); | ||
| if ($matchResult === 0) { |
There was a problem hiding this comment.
I've had the same problem in DBAL. If you change this check to…
if ($matchResult !== 1) {… you should not need the assert. Alternatively, we could think about using the composer/pcre library which has a saner API.
There was a problem hiding this comment.
@derrabus that's the solution I went first at first, but then I felt wrong because there's a tiny chance that false might occur and misdiagnose it as an invalid FQCN. composer/pcre might indeed be a good solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern is not dynamic, and we know it works. This addresses an issue reported by PHPStan.