Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused paramaters from DiffCommand and VersionCommand #1386

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

nikow13
Copy link
Contributor

@nikow13 nikow13 commented Dec 21, 2023

Q A
Type improvement
BC Break no
Fixed issues -

Summary

Remove unused parameter OutputInterface $output from DiffCommand & VersionCommand

@derrabus derrabus added this to the 3.8.0 milestone Mar 6, 2024
@derrabus derrabus changed the base branch from 3.7.x to 3.8.x March 6, 2024 13:57
@derrabus derrabus merged commit 7767cf4 into doctrine:3.8.x Mar 6, 2024
8 of 9 checks passed
derrabus added a commit to derrabus/migrations that referenced this pull request Mar 11, 2024
* 3.8.x:
  Raise PHPStan level to 8 (doctrine#1409)
  Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386)
  Simplify InlineParameterFormatterTest (doctrine#1411)
  fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
derrabus added a commit to derrabus/migrations that referenced this pull request Mar 11, 2024
* 3.8.x:
  Raise PHPStan level to 8 (doctrine#1409)
  Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386)
  Simplify InlineParameterFormatterTest (doctrine#1411)
  fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
derrabus added a commit to derrabus/migrations that referenced this pull request Mar 11, 2024
* 3.8.x:
  Fix CS
  Raise PHPStan level to 8 (doctrine#1409)
  Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386)
  Simplify InlineParameterFormatterTest (doctrine#1411)
  fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants