Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude phpstan file with .gitattributes #1346

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Exclude phpstan file with .gitattributes #1346

merged 2 commits into from
Jul 29, 2023

Conversation

VincentLanglet
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues

Summary

Same idea @greg0ire

There is also possibly

  • download-box.sh
  • build-phar.sh

but I don't know what there are doing

@greg0ire
Copy link
Member

They are used when running tests or running the phar, I think it is safe to remove them as well.

@VincentLanglet
Copy link
Contributor Author

They are used when running tests or running the phar, I think it is safe to remove them as well.

I added them

@greg0ire greg0ire added this to the 3.6.1 milestone Jul 29, 2023
@greg0ire greg0ire merged commit 832ef28 into doctrine:3.6.x Jul 29, 2023
@greg0ire
Copy link
Member

Thanks!

@greg0ire greg0ire mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @greg0ire